From 3d3b47975f25027b0dbc454f64fddea04a8c01f8 Mon Sep 17 00:00:00 2001 From: root Date: Wed, 13 Mar 2019 19:35:31 +0800 Subject: [PATCH 04/19] cov: dmeventd plugin fix memleak Fix memory leak when policy command fails too frequently and plugin decided to skip it. --- daemons/dmeventd/plugins/thin/dmeventd_thin.c | 2 +- daemons/dmeventd/plugins/vdo/dmeventd_vdo.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemons/dmeventd/plugins/thin/dmeventd_thin.c b/daemons/dmeventd/plugins/thin/dmeventd_thin.c index 29b0391..0330947 100644 --- a/daemons/dmeventd/plugins/thin/dmeventd_thin.c +++ b/daemons/dmeventd/plugins/thin/dmeventd_thin.c @@ -286,7 +286,7 @@ void process_event(struct dm_task *dmt, if (state->fails++ <= state->max_fails) { log_debug("Postponing frequently failing policy (%u <= %u).", state->fails - 1, state->max_fails); - return; + goto out; } if (state->max_fails < MAX_FAILS) state->max_fails <<= 1; diff --git a/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c b/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c index 389632c..6b35b2f 100644 --- a/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c +++ b/daemons/dmeventd/plugins/vdo/dmeventd_vdo.c @@ -261,7 +261,7 @@ void process_event(struct dm_task *dmt, if (state->fails++ <= state->max_fails) { log_debug("Postponing frequently failing policy (%u <= %u).", state->fails - 1, state->max_fails); - return; + goto out; } if (state->max_fails < MAX_FAILS) state->max_fails <<= 1; -- 2.19.1