Compare commits
11 Commits
951ee8d89a
...
13407db945
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
13407db945 | ||
|
|
39805ae0d7 | ||
|
|
6c45d40b0d | ||
|
|
18baf56cad | ||
|
|
ed04f66af1 | ||
|
|
32fd2ff5f5 | ||
|
|
4ae79e42bd | ||
|
|
f0163ae192 | ||
|
|
db0a3fbc21 | ||
|
|
ca313ed487 | ||
|
|
e37ee5f927 |
45
backport-do-not-rotate-old-logs-on-prerotate-failure.patch
Normal file
45
backport-do-not-rotate-old-logs-on-prerotate-failure.patch
Normal file
@ -0,0 +1,45 @@
|
|||||||
|
From 5f24239f282b8c6291cf35ea5f871ed0ca6b2672 Mon Sep 17 00:00:00 2001
|
||||||
|
From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com>
|
||||||
|
Date: Tue, 4 Apr 2023 17:49:06 +0200
|
||||||
|
Subject: [PATCH] do not rotate old logs on prerotate failure
|
||||||
|
|
||||||
|
Ensures old logs are preserved and not rotated out for logs with a
|
||||||
|
failing prerotate script.
|
||||||
|
|
||||||
|
Alternative to #502
|
||||||
|
---
|
||||||
|
logrotate.c | 14 ++++++++++----
|
||||||
|
1 files changed, 10 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/logrotate.c b/logrotate.c
|
||||||
|
index f44b3851..d3ccb447 100644
|
||||||
|
--- a/logrotate.c
|
||||||
|
+++ b/logrotate.c
|
||||||
|
@@ -2476,10 +2476,6 @@ static int rotateLogSet(const struct logInfo *log, int force)
|
||||||
|
return 1;
|
||||||
|
}
|
||||||
|
memset(rotNames[i], 0, sizeof(struct logNames));
|
||||||
|
-
|
||||||
|
- logHasErrors[i] |=
|
||||||
|
- prerotateSingleLog(log, i, state[i], rotNames[i]);
|
||||||
|
- hasErrors |= logHasErrors[i];
|
||||||
|
}
|
||||||
|
|
||||||
|
if (log->pre
|
||||||
|
@@ -2509,6 +2505,16 @@ static int rotateLogSet(const struct logInfo *log, int force)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
+ for (i = j;
|
||||||
|
+ ((log->flags & LOG_FLAG_SHAREDSCRIPTS) && i < log->numFiles)
|
||||||
|
+ || (!(log->flags & LOG_FLAG_SHAREDSCRIPTS) && i == j); i++) {
|
||||||
|
+ if (! ( (logHasErrors[i] && !(log->flags & LOG_FLAG_SHAREDSCRIPTS))
|
||||||
|
+ || (hasErrors && (log->flags & LOG_FLAG_SHAREDSCRIPTS)) ) ) {
|
||||||
|
+ logHasErrors[i] |= prerotateSingleLog(log, i, state[i], rotNames[i]);
|
||||||
|
+ hasErrors |= logHasErrors[i];
|
||||||
|
+ }
|
||||||
|
+ }
|
||||||
|
+
|
||||||
|
for (i = j;
|
||||||
|
((log->flags & LOG_FLAG_SHAREDSCRIPTS) && i < log->numFiles)
|
||||||
|
|| (!(log->flags & LOG_FLAG_SHAREDSCRIPTS) && i == j); i++) {
|
||||||
Binary file not shown.
Binary file not shown.
BIN
logrotate-3.21.0.tar.xz
Normal file
BIN
logrotate-3.21.0.tar.xz
Normal file
Binary file not shown.
@ -1,12 +1,15 @@
|
|||||||
%global _configure ../configure
|
%global _configure ../configure
|
||||||
|
|
||||||
Name: logrotate
|
Name: logrotate
|
||||||
Version: 3.18.1
|
Version: 3.21.0
|
||||||
Release: 1
|
Release: 1
|
||||||
Summary: simplify the administration of log files
|
Summary: simplify the administration of log files
|
||||||
License: GPLv2+
|
License: GPLv2+
|
||||||
Url: https://github.com/logrotate/logrotate
|
Url: https://github.com/logrotate/logrotate
|
||||||
Source0: https://github.com/logrotate/logrotate/releases/download/%{version}/logrotate-%{version}.tar.xz
|
Source0: https://github.com/logrotate/logrotate/releases/download/%{version}/logrotate-%{version}.tar.xz
|
||||||
|
|
||||||
|
Patch6001: backport-do-not-rotate-old-logs-on-prerotate-failure.patch
|
||||||
|
|
||||||
BuildRequires: acl gcc automake libacl-devel libselinux-devel popt-devel
|
BuildRequires: acl gcc automake libacl-devel libselinux-devel popt-devel
|
||||||
Requires: coreutils
|
Requires: coreutils
|
||||||
|
|
||||||
@ -57,7 +60,6 @@ fi
|
|||||||
%files
|
%files
|
||||||
%defattr(-,root,root)
|
%defattr(-,root,root)
|
||||||
%license COPYING
|
%license COPYING
|
||||||
%dir %{_sysconfdir}/cron.daily
|
|
||||||
%config(noreplace) %{_sysconfdir}/cron.daily/logrotate
|
%config(noreplace) %{_sysconfdir}/cron.daily/logrotate
|
||||||
%config(noreplace) %{_sysconfdir}/logrotate.conf
|
%config(noreplace) %{_sysconfdir}/logrotate.conf
|
||||||
%dir %{_sysconfdir}/logrotate.d
|
%dir %{_sysconfdir}/logrotate.d
|
||||||
@ -73,6 +75,18 @@ fi
|
|||||||
%{_mandir}/man5/logrotate.conf.5*
|
%{_mandir}/man5/logrotate.conf.5*
|
||||||
|
|
||||||
%changelog
|
%changelog
|
||||||
|
* Sun Feb 4 2024 hanhuihui <hanhuihui5@huawei.com> - 3.21.0-1
|
||||||
|
- upgrade version to 3.21.0
|
||||||
|
|
||||||
|
* Thu Jan 11 2024 hanhuihui <hanhuihui5@huawei.com> - 3.20.1-3
|
||||||
|
- do not pack directories belonging to other packages
|
||||||
|
|
||||||
|
* Mon Jun 5 2023 hanhuihui <hanhuihui5@huawei.com> - 3.20.1-2
|
||||||
|
- do not rotate old logs on prerotate failure
|
||||||
|
|
||||||
|
* Fri Jun 10 2022 duyiwei <duyiwei@kylinos.cn> - 3.20.1-1
|
||||||
|
- upgrade version to 3.20.1 and fix CVE-2022-1348
|
||||||
|
|
||||||
* Sat Nov 20 2021 xiechengliang <xiechengliang1@huawei.com> - 3.18.1-1
|
* Sat Nov 20 2021 xiechengliang <xiechengliang1@huawei.com> - 3.18.1-1
|
||||||
- update upstream to 3.18.1
|
- update upstream to 3.18.1
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user