77 lines
2.5 KiB
Diff
77 lines
2.5 KiB
Diff
From d72b85480695e15f1ffdd7cd91ddecc4608467c6 Mon Sep 17 00:00:00 2001
|
|
From: liumengqiu <liumengqiu1@huawei.com>
|
|
Date: Thu, 25 Aug 2022 20:22:02 +0800
|
|
Subject: [PATCH 05/13] tests: add explicit test case for pflash loader lacking
|
|
path
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The following is expected to raise an error:
|
|
|
|
<os>
|
|
<loader readonly='yes' type='pflash'/>
|
|
</os>
|
|
|
|
because no path to the pflash loader is given and there is
|
|
no default built-in.
|
|
|
|
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
|
|
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
Signed-off-by: liumengqiu <liumengqiu1@huawei.com>
|
|
---
|
|
tests/qemuxml2argvdata/bios-nvram-no-path.err | 1 +
|
|
tests/qemuxml2argvdata/bios-nvram-no-path.xml | 19 +++++++++++++++++++
|
|
tests/qemuxml2argvtest.c | 1 +
|
|
3 files changed, 21 insertions(+)
|
|
create mode 100644 tests/qemuxml2argvdata/bios-nvram-no-path.err
|
|
create mode 100644 tests/qemuxml2argvdata/bios-nvram-no-path.xml
|
|
|
|
diff --git a/tests/qemuxml2argvdata/bios-nvram-no-path.err b/tests/qemuxml2argvdata/bios-nvram-no-path.err
|
|
new file mode 100644
|
|
index 0000000000..795386008c
|
|
--- /dev/null
|
|
+++ b/tests/qemuxml2argvdata/bios-nvram-no-path.err
|
|
@@ -0,0 +1 @@
|
|
+no loader path specified and firmware auto selection disabled
|
|
diff --git a/tests/qemuxml2argvdata/bios-nvram-no-path.xml b/tests/qemuxml2argvdata/bios-nvram-no-path.xml
|
|
new file mode 100644
|
|
index 0000000000..bf97f0bdd6
|
|
--- /dev/null
|
|
+++ b/tests/qemuxml2argvdata/bios-nvram-no-path.xml
|
|
@@ -0,0 +1,19 @@
|
|
+<domain type='qemu'>
|
|
+ <name>test-bios</name>
|
|
+ <uuid>362d1fc1-df7d-193e-5c18-49a71bd1da66</uuid>
|
|
+ <memory unit='KiB'>1048576</memory>
|
|
+ <currentMemory unit='KiB'>1048576</currentMemory>
|
|
+ <vcpu placement='static'>1</vcpu>
|
|
+ <os>
|
|
+ <type arch='x86_64' machine='pc'>hvm</type>
|
|
+ <loader readonly='yes' type='pflash'/>
|
|
+ <boot dev='hd'/>
|
|
+ <bootmenu enable='yes'/>
|
|
+ </os>
|
|
+ <features>
|
|
+ <acpi/>
|
|
+ </features>
|
|
+ <devices>
|
|
+ <emulator>/usr/bin/qemu-system-x86_64</emulator>
|
|
+ </devices>
|
|
+</domain>
|
|
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
|
|
index d37969d065..e3ecd37c2b 100644
|
|
--- a/tests/qemuxml2argvtest.c
|
|
+++ b/tests/qemuxml2argvtest.c
|
|
@@ -990,6 +990,7 @@ mymain(void)
|
|
QEMU_CAPS_DEVICE_ISA_SERIAL,
|
|
QEMU_CAPS_SGA);
|
|
DO_TEST("bios-nvram", NONE);
|
|
+ DO_TEST_PARSE_ERROR("bios-nvram-no-path", NONE);
|
|
DO_TEST("bios-nvram-secure",
|
|
QEMU_CAPS_DEVICE_DMI_TO_PCI_BRIDGE,
|
|
QEMU_CAPS_DEVICE_PCI_BRIDGE,
|
|
--
|
|
2.33.0
|
|
|