307ea8abab
- docs: Document CPU clusters - docs: Improve documentation for CPU topology - tests: Verify handling of CPU clusters in QMP data - qemu: Make monitor aware of CPU clusters - qemu: Use CPU clusters for guests - qemu: Introduce QEMU_CAPS_SMP_CLUSTERS - conf: Allow specifying CPU clusters - conf: Report CPU clusters in capabilities XML - tests: Add hostcpudata for machine with CPU clusters - cpu_map: add kunpeng-920 features to arm features - cpu/aarch64: enable host-model cpu for AArch64 architecture - conf/domain_conf: pin the retry_interval and retry_timeout parameters to xml - nodedev: fix potential heap use after free - libvirt/conf: Set default values of retry fileds - qemu: Support 'retry' BLOCK_IO_ERROR event. - libvirt: Add 'retry' support for error policy - vdpa: support vdpa device migrate - vdpa: support vdpa device hot plug/unplug - hostdev:Introduce vDPA device to hostdev subsystem as a new subtype - node_device: fix leak of DIR* - migration/multifd-pin: support migration multifd thread pin - migration/multifd-pin: add qemu monitor callback functions - migration/migration-pin: add domainMigrationPid for qemuMonitorCallbacks - migration/migration-pin: add migrationpin for migration parameters - migration/migration-pin: add qemu monitor callback functions - migration/migration-pin:add some migration/multiFd params - qemu: add pointer check in qemuMonitorLastError - qemu: fix a concurrent operation situation - test/commandtest: skip the test4 if the testcase is run in the container env Signed-off-by: Jiabo Feng <fengjiabo1@huawei.com>
48 lines
1.6 KiB
Diff
48 lines
1.6 KiB
Diff
From 3cd86072fd6725178b669174eb99ab24a0bcee6c Mon Sep 17 00:00:00 2001
|
|
From: AlexChen <alex.chen@huawei.com>
|
|
Date: Tue, 27 Oct 2020 21:43:47 -0400
|
|
Subject: [PATCH] node_device: fix leak of DIR*
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
Commit 53aec799fa31 introduced the function udevGetVDPACharDev(),
|
|
which scans a directory using virDirOpenIfExists() and
|
|
virDirRead(). It unfortunately forgets to close the DIR* when it is
|
|
finished with it. This patch fixes that omission.
|
|
|
|
Fixes: 53aec799fa31711ffaeacc7ec17ec6d3c2e3cadf
|
|
Signed-off-by: Laine Stump <laine@redhat.com>
|
|
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
Signed-off-by: AlexChen <alex.chen@huawei.com>
|
|
---
|
|
src/node_device/node_device_udev.c | 4 ++++
|
|
1 file changed, 4 insertions(+)
|
|
|
|
diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
|
|
index 911325600e..c82d3e7dea 100644
|
|
--- a/src/node_device/node_device_udev.c
|
|
+++ b/src/node_device/node_device_udev.c
|
|
@@ -1198,6 +1198,7 @@ udevGetVDPACharDev(const char *sysfs_path,
|
|
virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
_("vDPA chardev path '%1$s' does not exist"),
|
|
chardev);
|
|
+ virDirClose(dir);
|
|
return -1;
|
|
}
|
|
VIR_DEBUG("vDPA chardev is at '%s'", chardev);
|
|
@@ -1206,6 +1207,9 @@ udevGetVDPACharDev(const char *sysfs_path,
|
|
break;
|
|
}
|
|
}
|
|
+
|
|
+ virDirClose(dir);
|
|
+
|
|
if (direrr < 0)
|
|
return -1;
|
|
|
|
--
|
|
2.27.0
|
|
|