From 654c77db8239678b3154590f16e7c7c1da557c89 Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Tue, 16 Jun 2020 08:07:03 -0400 Subject: [PATCH 004/108] util: Fix memory leak in virAuthConfigLookup Since 5084091a, @authcred is filled by a g_key_file_get_string which is now an allocated string as opposed to some hash table lookup value, so we need to treat it as so. Found by Coverity Signed-off-by: John Ferlan Reviewed-by: Peter Krempa (cherry picked from commit d25758141723d45aecd368ee3e5183ccb5c7eea2) --- src/util/virauthconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virauthconfig.c b/src/util/virauthconfig.c index 1c007757c7..0da9c2461f 100644 --- a/src/util/virauthconfig.c +++ b/src/util/virauthconfig.c @@ -103,7 +103,7 @@ int virAuthConfigLookup(virAuthConfigPtr auth, { g_autofree char *authgroup = NULL; g_autofree char *credgroup = NULL; - const char *authcred; + g_autofree char *authcred = NULL; *value = NULL; -- 2.33.0