packages/libvirt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libvirt update to version 9.10.0-7:

Browse Source 
remote_driver: Restore special behavior of remoteDomainGetBlockIoTune()

Signed-off-by: shenyage <shenyage1@huawei.com>
This commit is contained in:
shenyage 2024-04-29 20:58:43 +08:00
parent c6294c3eef
commit 2b5df66bb7
2 changed files with 50 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libvirt.spec
View File

@ -262,7 +262,7 @@
Summary: Library providing a simple virtualization API
Name: libvirt
Version: 9.10.0
Release: 6
Release: 7
License: LGPLv2+
URL: https://libvirt.org/
@ -313,6 +313,7 @@ Patch0039: Fix-warnings-found-by-clang.patch
Patch0040: Fix-off-by-one-error-in-udevListInterfacesByStatus.patch
Patch0041: remote-check-for-negative-array-lengths-before-alloc.patch
Patch0042: hotpatch-if-hotpatch_path-not-in-qemu.conf-the-hotpa.patch
Patch0043: remote_driver-Restore-special-behavior-of-remoteDoma.patch
Requires: libvirt-daemon = %{version}-%{release}
Requires: libvirt-daemon-config-network = %{version}-%{release}
@ -2604,6 +2605,9 @@ exit 0
%endif
%changelog
* Mon Apr 29 2024 YageShen <shenyage1@huawei.com> - 9.10.0-7
- remote_driver: Restore special behavior of remoteDomainGetBlockIoTune()
* Thu Apr 11 2024 JiaboFeng <fengjiabo1@huawei.com> - 9.10.0-6
- spec: remove libxml2 dependency

45
remote_driver-Restore-special-behavior-of-remoteDoma.patch Normal file
View File

@ -0,0 +1,45 @@
From 65298ef17e3c16a6eeb2ea33671fa26633a0a7d9 Mon Sep 17 00:00:00 2001
From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 29 Jan 2024 10:07:05 +0100
Subject: [PATCH] remote_driver: Restore special behavior of
remoteDomainGetBlockIoTune()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
In v9.10.0-rc1~103 the remote driver was switched to g_auto() for
client RPC return parameters. But whilst doing so a small bug
slipped in: previously, when virDomainGetBlockIoTune() was called
with *nparams == 0, the function set *nparams to the number of
supported params and zero was returned (so that client can
allocate memory and call the API second time). IOW - the usual,
old style of APIs where we didn't want to allocate memory on
caller's behalf. But because of this bug, a negative one is
returned instead.
Fixes: 501825011c1fe80f458820c7efe5a198e0af9be5
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
ref: https://github.com/libvirt/libvirt/commit/3a3f73ea9f1925ca5e256fa54c5aa451ddeaa19e
Signed-off-by: shenyage <shenyage1@huawei.com>
---
src/remote/remote_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
index 25fae1cad6..a1a0edd7a2 100644
--- a/src/remote/remote_driver.c
+++ b/src/remote/remote_driver.c
@@ -2577,7 +2577,7 @@ static int remoteDomainGetBlockIoTune(virDomainPtr domain,
*/
if (*nparams == 0) {
*nparams = ret.nparams;
- return -1;
+ return 0;
}
if (virTypedParamsDeserialize((struct _virTypedParameterRemote *) ret.params.params_val,
--
2.43.0.windows.1