41 lines
1.4 KiB
Diff
41 lines
1.4 KiB
Diff
|
From 6c4265c15abd446e050f955cccb41d22f8456969 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Martin Kletzander <mkletzan@redhat.com>
|
||
|
|
Date: Thu, 9 Jul 2020 09:27:41 +0200
|
||
|
|
Subject: [PATCH 6/6] resctrl: Do not open directory for writing
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
When preparing for the removal of GNULIB commit 18dca21a32e9 removed the
|
||
|
|
unneeded O_DIRECTORY, but unfortunately started opening the directory for
|
||
|
|
writing which fails every time for a directory. There is also no need for that
|
||
|
|
as flock() works on O_RDONLY file descriptor as well, even for LOCK_EX.
|
||
|
|
|
||
|
|
https://bugzilla.redhat.com/1852741
|
||
|
|
|
||
|
|
cherry pick from: 9d832813820b948eb508508fb3cbd86c90698119
|
||
|
|
|
||
|
|
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
|
||
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
||
|
|
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
|
||
|
|
---
|
||
|
|
src/util/virresctrl.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
|
||
|
|
index c537d60..937a053 100644
|
||
|
|
--- a/src/util/virresctrl.c
|
||
|
|
+++ b/src/util/virresctrl.c
|
||
|
|
@@ -456,7 +456,7 @@ VIR_ONCE_GLOBAL_INIT(virResctrl);
|
||
|
|
static int
|
||
|
|
virResctrlLockWrite(void)
|
||
|
|
{
|
||
|
|
- int fd = open(SYSFS_RESCTRL_PATH, O_RDWR | O_CLOEXEC);
|
||
|
|
+ int fd = open(SYSFS_RESCTRL_PATH, O_RDONLY | O_CLOEXEC);
|
||
|
|
|
||
|
|
if (fd < 0) {
|
||
|
|
virReportSystemError(errno, "%s", _("Cannot open resctrl"));
|
||
|
|
--
|
||
|
|
1.8.3.1
|
||
|
|
|