33 lines
1.0 KiB
Diff
33 lines
1.0 KiB
Diff
|
From 05a25f4c74e0e5c93703302a36b55a63b754d995 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Michal Privoznik <mprivozn@redhat.com>
|
||
|
|
Date: Mon, 31 Jan 2022 13:52:25 +0100
|
||
|
|
Subject: [PATCH 04/13] test_driver: Don't leak @group_name
|
||
|
|
|
||
|
|
In testDomainSetBlockIoTune() the info.group_name is strdup()-ed
|
||
|
|
and just after the whole @info structure is passed to
|
||
|
|
virDomainDiskSetBlockIOTune() the @group_name member is set to
|
||
|
|
NULL. This creates a memleak, because
|
||
|
|
virDomainDiskSetBlockIOTune() creates its own copy of the string.
|
||
|
|
|
||
|
|
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
||
|
|
Reviewed-by: Erik Skultety <eskultet@redhat.com>
|
||
|
|
---
|
||
|
|
src/test/test_driver.c | 1 -
|
||
|
|
1 file changed, 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
|
||
|
|
index 33f1792177..e0d9c4fa0b 100644
|
||
|
|
--- a/src/test/test_driver.c
|
||
|
|
+++ b/src/test/test_driver.c
|
||
|
|
@@ -3845,7 +3845,6 @@ testDomainSetBlockIoTune(virDomainPtr dom,
|
||
|
|
|
||
|
|
if (virDomainDiskSetBlockIOTune(conf_disk, &info) < 0)
|
||
|
|
goto cleanup;
|
||
|
|
- info.group_name = NULL;
|
||
|
|
|
||
|
|
ret = 0;
|
||
|
|
cleanup:
|
||
|
|
--
|
||
|
|
2.33.0
|
||
|
|
|