37 lines
1.4 KiB
Diff
37 lines
1.4 KiB
Diff
|
From 9c6ee47619deb2553dafd498ba03aff29a484069 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Michal Privoznik <mprivozn@redhat.com>
|
||
|
|
Date: Fri, 18 Dec 2020 16:09:13 +0100
|
||
|
|
Subject: [PATCH 025/108] networkGetDHCPLeases: Use VIR_APPEND_ELEMENT()
|
||
|
|
instead of VIR_INSERT_ELEMENT()
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
This function is misusing VIR_INSERT_ELEMENT() to behave like
|
||
|
|
VIR_APPEND_ELEMENT(). Use the latter to make it explicit what we
|
||
|
|
are trying to achieve.
|
||
|
|
|
||
|
|
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
||
|
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
(cherry picked from commit ee93656c40467fa614e999a146a56011a9c500e3)
|
||
|
|
---
|
||
|
|
src/network/bridge_driver.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
|
||
|
|
index f06099297a..21d02dd304 100644
|
||
|
|
--- a/src/network/bridge_driver.c
|
||
|
|
+++ b/src/network/bridge_driver.c
|
||
|
|
@@ -4322,7 +4322,7 @@ networkGetDHCPLeases(virNetworkPtr net,
|
||
|
|
lease->clientid = g_strdup(virJSONValueObjectGetString(lease_tmp, "client-id"));
|
||
|
|
lease->hostname = g_strdup(virJSONValueObjectGetString(lease_tmp, "hostname"));
|
||
|
|
|
||
|
|
- if (VIR_INSERT_ELEMENT(leases_ret, nleases, nleases, lease) < 0)
|
||
|
|
+ if (VIR_APPEND_ELEMENT(leases_ret, nleases, lease) < 0)
|
||
|
|
goto error;
|
||
|
|
|
||
|
|
} else {
|
||
|
|
--
|
||
|
|
2.33.0
|
||
|
|
|