45 lines
1.7 KiB
Diff
45 lines
1.7 KiB
Diff
From f4a761fb66512fff59798765e8ac5b9e57dceef0 Mon Sep 17 00:00:00 2001
|
|
From: Patrick Griffis <pgriffis@igalia.com>
|
|
Date: Fri, 27 Dec 2024 18:00:39 -0600
|
|
Subject: [PATCH] soup_message_headers_get_content_disposition: strdup
|
|
truncated filenames
|
|
|
|
This table frees the strings it contains.
|
|
|
|
Conflict: NA
|
|
Reference: https://gitlab.gnome.org/GNOME/libsoup/-/commit/f4a761fb66512fff59798765e8ac5b9e57dceef0
|
|
|
|
---
|
|
libsoup/soup-message-headers.c | 2 +-
|
|
tests/header-parsing-test.c | 1 +
|
|
2 files changed, 2 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/libsoup/soup-message-headers.c b/libsoup/soup-message-headers.c
|
|
index a577169..81e7cea 100644
|
|
--- a/libsoup/soup-message-headers.c
|
|
+++ b/libsoup/soup-message-headers.c
|
|
@@ -1458,7 +1458,7 @@ soup_message_headers_get_content_disposition (SoupMessageHeaders *hdrs,
|
|
char *filename = strrchr (orig_value, '/');
|
|
|
|
if (filename)
|
|
- g_hash_table_insert (*params, g_strdup (orig_key), filename + 1);
|
|
+ g_hash_table_insert (*params, g_strdup (orig_key), g_strdup (filename + 1));
|
|
} else {
|
|
/* filename with no value isn't valid. */
|
|
g_hash_table_remove (*params, "filename");
|
|
diff --git a/tests/header-parsing-test.c b/tests/header-parsing-test.c
|
|
index 45316c5..c3a62f9 100644
|
|
--- a/tests/header-parsing-test.c
|
|
+++ b/tests/header-parsing-test.c
|
|
@@ -1174,6 +1174,7 @@ do_content_disposition_tests (void)
|
|
soup_test_assert (FALSE, "empty filename decoding FAILED");
|
|
return;
|
|
}
|
|
+ g_free (disposition);
|
|
g_assert_false (g_hash_table_contains (params, "filename"));
|
|
g_hash_table_destroy (params);
|
|
|
|
--
|
|
2.48.1
|
|
|