From e2e3d1cf16a15d725289e3f5a8a6503de08fc63f Mon Sep 17 00:00:00 2001 From: Patrick Griffis Date: Tue, 11 Feb 2025 10:32:39 -0600 Subject: [PATCH] Remove redundant function The nonce is validated earlier now. Conflict: Modify file path adaptation: libsoup/auth/soup-auth-digest.c->libsoup/soup-auth-digest.c Reference: https://gitlab.gnome.org/GNOME/libsoup/-/commit/e2e3d1cf16a15d725289e3f5a8a6503de08fc63f --- libsoup/soup-auth-digest.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/libsoup/soup-auth-digest.c b/libsoup/soup-auth-digest.c index 40b470b..318ebe2 100644 --- a/libsoup/soup-auth-digest.c +++ b/libsoup/soup-auth-digest.c @@ -133,19 +133,6 @@ soup_auth_digest_get_qop (SoupAuthDigestQop qop) return g_string_free (out, FALSE); } -static gboolean -validate_params (SoupAuthDigest *auth_digest) -{ - SoupAuthDigestPrivate *priv = soup_auth_digest_get_instance_private (auth_digest); - - if (priv->qop || priv->algorithm == SOUP_AUTH_DIGEST_ALGORITHM_MD5_SESS) { - if (!priv->nonce) - return FALSE; - } - - return TRUE; -} - static gboolean soup_auth_digest_update (SoupAuth *auth, SoupMessage *msg, GHashTable *auth_params) @@ -183,9 +170,6 @@ soup_auth_digest_update (SoupAuth *auth, SoupMessage *msg, if (priv->algorithm == -1) ok = FALSE; - if (!validate_params (auth_digest)) - ok = FALSE; - if (ok) { stale = g_hash_table_lookup (auth_params, "stale"); if (stale && !g_ascii_strcasecmp (stale, "TRUE") && *priv->hex_urp) -- 2.48.1