From 5d419fa4d4144c63a2b8458ab1871167a44bf490 Mon Sep 17 00:00:00 2001 From: Bin Hu Date: Sat, 26 Mar 2022 14:19:50 +0800 Subject: [PATCH 4/6] fix NULL pointer dereference in initial_state_start_fun Signed-off-by: Bin Hu --- lib/metalink_pstate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/metalink_pstate.c b/lib/metalink_pstate.c index 0a32461..3078338 100644 --- a/lib/metalink_pstate.c +++ b/lib/metalink_pstate.c @@ -100,7 +100,7 @@ void initial_state_start_fun(metalink_pstm_t* stm, const char** attrs) { if(strcmp("metalink", name) == 0) { - if (strcmp(METALINK_V3_NS_URI, ns_uri) == 0) { + if (ns_uri && strcmp(METALINK_V3_NS_URI, ns_uri) == 0) { const char* type; const char* origin; metalink_pctrl_set_version(stm->ctrl, METALINK_VERSION_3); @@ -116,7 +116,7 @@ void initial_state_start_fun(metalink_pstm_t* stm, metalink_pstm_enter_metalink_state(stm); } - else if (strcmp(METALINK_V4_NS_URI, ns_uri) == 0) { + else if (ns_uri && strcmp(METALINK_V4_NS_URI, ns_uri) == 0) { metalink_pctrl_set_version(stm->ctrl, METALINK_VERSION_4); metalink_pstm_enter_metalink_state_v4(stm); } else { -- 2.28.0.windows.1