libical/libical-bugfix-attempt-to-make-Coverity-happy.patch

32 lines
1.2 KiB
Diff
Raw Normal View History

2020-03-10 17:14:31 +08:00
From 5048c2e6084bc0df1a80416bf9760f03e243bb09 Mon Sep 17 00:00:00 2001
From: Allen Winter <allen.winter@kdab.com>
Date: Sun, 12 May 2019 16:55:44 -0400
Subject: [PATCH] another attempt to make Coverity happy
---
src/libical/icalparser.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/libical/icalparser.c b/src/libical/icalparser.c
index 6d54a7c..de7a2a4 100644
--- a/src/libical/icalparser.c
+++ b/src/libical/icalparser.c
@@ -1004,7 +1004,13 @@ icalcomponent *icalparser_add_line(icalparser *parser, char *line)
/* Reparse the parameter name and value with the new segment */
if (!parser_get_param_name_stack(str, name_stack, sizeof(name_stack),
pvalue_stack, sizeof(pvalue_stack))) {
- if (name_heap) {
+
+ if (pvalue_heap) {
+ icalmemory_free_buffer(pvalue_heap);
+ pvalue_heap = 0;
+ pvalue = 0;
+ }
+ if (name_heap) {
icalmemory_free_buffer(name_heap);
name = 0;
}
--
2.19.1