30 lines
942 B
Diff
30 lines
942 B
Diff
From fd284bda6f7430b2e939f95c6836c972e22a2eb4 Mon Sep 17 00:00:00 2001
|
|
From: Marek Blaha <mblaha@redhat.com>
|
|
Date: Tue, 26 Mar 2024 14:09:47 +0100
|
|
Subject: [PATCH 293/300] subject-py: Fix memory leak
|
|
|
|
Posible memory leak was detected in get_best_solution() method.
|
|
---
|
|
python/hawkey/subject-py.cpp | 4 +++-
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/python/hawkey/subject-py.cpp b/python/hawkey/subject-py.cpp
|
|
index a88d572a..3e1919e7 100644
|
|
--- a/python/hawkey/subject-py.cpp
|
|
+++ b/python/hawkey/subject-py.cpp
|
|
@@ -361,8 +361,10 @@ get_best_solution(_SubjectObject *self, PyObject *args, PyObject *kwds)
|
|
HyNevra nevra{nullptr};
|
|
|
|
UniquePtrPyObject q(get_solution(self, args, kwds, &nevra));
|
|
- if (!q)
|
|
+ if (!q) {
|
|
+ delete nevra;
|
|
return NULL;
|
|
+ }
|
|
PyObject *ret_dict = PyDict_New();
|
|
PyDict_SetItem(ret_dict, PyString_FromString("query"), q.get());
|
|
if (nevra) {
|
|
--
|
|
2.33.0
|
|
|