51 lines
1.9 KiB
Diff
51 lines
1.9 KiB
Diff
|
From a2263db66eb8ae10614ac1c4ab942bda8c7cd78c Mon Sep 17 00:00:00 2001
|
||
|
|
From: Xiaole He via Libabigail <libabigail@sourceware.org>
|
||
|
|
Date: Mon, 19 Sep 2022 18:03:50 +0800
|
||
|
|
Subject: [PATCH] abg-reader: fix comment of function
|
||
|
|
|
||
|
|
In 'src/abg-reader.cc', the function
|
||
|
|
'walk_xml_node_to_map_type_ids(read_context& ctxt, xmlNodePtr node)'
|
||
|
|
finds all of the child nodes of 'node' that has the 'id' attribute,
|
||
|
|
and then put the child node into map where the 'id' of the child node
|
||
|
|
as key and the child node itself as the value.
|
||
|
|
But the comment for this function writes:
|
||
|
|
/* src/abg-reader.cc begin */
|
||
|
|
/// Walk an entire XML sub-tree to build a map where the key is the
|
||
|
|
/// the value of the 'id' attribute (for type definitions) and the key
|
||
|
|
/// is the xml node containing the 'id' attribute.
|
||
|
|
...
|
||
|
|
static void
|
||
|
|
walk_xml_node_to_map_type_ids(read_context& ctxt,
|
||
|
|
xmlNodePtr node)
|
||
|
|
...
|
||
|
|
/* src/abg-reader.cc end */
|
||
|
|
The second and third lines of the comment above says the the child node
|
||
|
|
as the key of the map, but it should be the value of the map.
|
||
|
|
This patch fix the problematic comment described above, from
|
||
|
|
'and the key is the xml node' to 'and the value is the xml node'.
|
||
|
|
|
||
|
|
* src/abg-reader.cc (walk_xml_node_to_map_type_ids): fix comment
|
||
|
|
|
||
|
|
Signed-off-by: Xiaole He <hexiaole@kylinos.cn>
|
||
|
|
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
|
||
|
|
---
|
||
|
|
src/abg-reader.cc | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/abg-reader.cc b/src/abg-reader.cc
|
||
|
|
index 1ca36b7..1df3515 100644
|
||
|
|
--- a/src/abg-reader.cc
|
||
|
|
+++ b/src/abg-reader.cc
|
||
|
|
@@ -1418,7 +1418,7 @@ advance_cursor(read_context& ctxt)
|
||
|
|
}
|
||
|
|
|
||
|
|
/// Walk an entire XML sub-tree to build a map where the key is the
|
||
|
|
-/// the value of the 'id' attribute (for type definitions) and the key
|
||
|
|
+/// the value of the 'id' attribute (for type definitions) and the value
|
||
|
|
/// is the xml node containing the 'id' attribute.
|
||
|
|
///
|
||
|
|
/// @param ctxt the context of the reader.
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|