30 lines
877 B
Diff
30 lines
877 B
Diff
|
From c8ef1946266f8ab4f4cdfb9675aad780087420c4 Mon Sep 17 00:00:00 2001
|
||
|
|
From: cglosner <cglosner@gmail.com>
|
||
|
|
Date: Sun, 26 Nov 2023 11:17:17 -0500
|
||
|
|
Subject: [PATCH] libknet/tests: fix potential overflow with sprintf
|
||
|
|
|
||
|
|
---
|
||
|
|
libknet/tests/knet_bench.c | 4 ++--
|
||
|
|
1 file changed, 2 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/libknet/tests/knet_bench.c b/libknet/tests/knet_bench.c
|
||
|
|
index d9b9deea..674febb3 100644
|
||
|
|
--- a/libknet/tests/knet_bench.c
|
||
|
|
+++ b/libknet/tests/knet_bench.c
|
||
|
|
@@ -129,10 +129,10 @@ static void parse_nodes(char *nodesinfo[MAX_NODES], int onidx, int port, struct
|
||
|
|
{
|
||
|
|
int i;
|
||
|
|
char *temp = NULL;
|
||
|
|
- char port_str[10];
|
||
|
|
+ char port_str[11];
|
||
|
|
|
||
|
|
memset(port_str, 0, sizeof(port_str));
|
||
|
|
- sprintf(port_str, "%d", port);
|
||
|
|
+ snprintf(port_str, sizeof(port_str), "%d", port);
|
||
|
|
|
||
|
|
for (i = 0; i < onidx; i++) {
|
||
|
|
nodes[i].nodeid = atoi(strtok(nodesinfo[i], ","));
|
||
|
|
--
|
||
|
|
2.25.1
|
||
|
|
|