51 lines
1.7 KiB
Diff
51 lines
1.7 KiB
Diff
|
From bc4fddc3b306b204c5af664656ae62a1f23e2aab Mon Sep 17 00:00:00 2001
|
||
|
|
From: Bjorn Helgaas <bhelgaas@google.com>
|
||
|
|
Date: Wed, 18 Jan 2023 17:46:08 -0600
|
||
|
|
Subject: [PATCH] iavf: Remove redundant pci_enable_pcie_error_reporting()
|
||
|
|
|
||
|
|
pci_enable_pcie_error_reporting() enables the device to send ERR_*
|
||
|
|
Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
|
||
|
|
native"), the PCI core does this for all devices during enumeration.
|
||
|
|
|
||
|
|
Remove the redundant pci_enable_pcie_error_reporting() call from the
|
||
|
|
driver. Also remove the corresponding pci_disable_pcie_error_reporting()
|
||
|
|
from the driver .remove() path.
|
||
|
|
|
||
|
|
Note that this doesn't control interrupt generation by the Root Port; that
|
||
|
|
is controlled by the AER Root Error Command register, which is managed by
|
||
|
|
the AER service driver.
|
||
|
|
|
||
|
|
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
|
||
|
|
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
|
||
|
|
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
|
||
|
|
Cc: intel-wired-lan@lists.osuosl.org
|
||
|
|
Cc: netdev@vger.kernel.org
|
||
|
|
Tested-by: Marek Szlosek <marek.szlosek@intel.com>
|
||
|
|
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
|
||
|
|
---
|
||
|
|
src/iavf_main.c | 5 -----
|
||
|
|
1 file changed, 5 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/src/iavf_main.c b/src/iavf_main.c
|
||
|
|
index 2c4480b20db3a5..3273aeb8fa6763 100644
|
||
|
|
--- a/src/iavf_main.c
|
||
|
|
+++ b/src/iavf_main.c
|
||
|
|
@@ -4868,8 +4868,6 @@ static int iavf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
||
|
|
goto err_pci_reg;
|
||
|
|
}
|
||
|
|
|
||
|
|
- pci_enable_pcie_error_reporting(pdev);
|
||
|
|
-
|
||
|
|
pci_set_master(pdev);
|
||
|
|
|
||
|
|
netdev = alloc_etherdev_mq(sizeof(struct iavf_adapter),
|
||
|
|
@@ -5175,8 +5172,6 @@ static void iavf_remove(struct pci_dev *pdev)
|
||
|
|
|
||
|
|
free_netdev(netdev);
|
||
|
|
|
||
|
|
- pci_disable_pcie_error_reporting(pdev);
|
||
|
|
-
|
||
|
|
pci_disable_device(pdev);
|
||
|
|
}
|
||
|
|
|