83 lines
3.1 KiB
Diff
83 lines
3.1 KiB
Diff
From a65a2b54e18a7e269bff32526b4180ece22e9aa6 Mon Sep 17 00:00:00 2001
|
|
From: Damien Neil <dneil@google.com>
|
|
Date: Thu, 28 Mar 2024 16:57:51 -0700
|
|
Subject: [PATCH] [Backport] net/http: update bundled golang.org/x/net/http2
|
|
|
|
Offering: Cloud Core Network
|
|
CVE: CVE-2023-45288
|
|
Reference: https://go-review.googlesource.com/c/go/+/576076
|
|
|
|
Disable cmd/internal/moddeps test, since this update includes PRIVATE
|
|
track fixes.
|
|
|
|
Fixes CVE-2023-45288
|
|
For #65051
|
|
Fixes #66298
|
|
|
|
Change-Id: I5bbf774ebe7651e4bb7e55139d3794bd2b8e8fa8
|
|
Reviewed-on: https://team-review.git.corp.google.com/c/golang/go-private/+/2197227
|
|
Reviewed-by: Tatiana Bradley <tatianabradley@google.com>
|
|
Run-TryBot: Damien Neil <dneil@google.com>
|
|
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
|
|
Reviewed-on: https://go-review.googlesource.com/c/go/+/576076
|
|
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
|
|
TryBot-Bypass: Dmitri Shuralyov <dmitshur@google.com>
|
|
Reviewed-by: Than McIntosh <thanm@google.com>
|
|
Signed-off-by: Ma Chang Wang machangwang@huawei.com
|
|
---
|
|
src/net/http/h2_bundle.go | 31 +++++++++++++++++++++++++++++++
|
|
1 file changed, 31 insertions(+)
|
|
|
|
diff --git a/src/net/http/h2_bundle.go b/src/net/http/h2_bundle.go
|
|
index dd59e1f4f2..cd95f84269 100644
|
|
--- a/src/net/http/h2_bundle.go
|
|
+++ b/src/net/http/h2_bundle.go
|
|
@@ -2966,6 +2966,7 @@ func (fr *http2Framer) readMetaFrame(hf *http2HeadersFrame) (*http2MetaHeadersFr
|
|
if size > remainSize {
|
|
hdec.SetEmitEnabled(false)
|
|
mh.Truncated = true
|
|
+ remainSize = 0
|
|
return
|
|
}
|
|
remainSize -= size
|
|
@@ -2978,6 +2979,36 @@ func (fr *http2Framer) readMetaFrame(hf *http2HeadersFrame) (*http2MetaHeadersFr
|
|
var hc http2headersOrContinuation = hf
|
|
for {
|
|
frag := hc.HeaderBlockFragment()
|
|
+
|
|
+ // Avoid parsing large amounts of headers that we will then discard.
|
|
+ // If the sender exceeds the max header list size by too much,
|
|
+ // skip parsing the fragment and close the connection.
|
|
+ //
|
|
+ // "Too much" is either any CONTINUATION frame after we've already
|
|
+ // exceeded the max header list size (in which case remainSize is 0),
|
|
+ // or a frame whose encoded size is more than twice the remaining
|
|
+ // header list bytes we're willing to accept.
|
|
+ if int64(len(frag)) > int64(2*remainSize) {
|
|
+ if http2VerboseLogs {
|
|
+ log.Printf("http2: header list too large")
|
|
+ }
|
|
+ // It would be nice to send a RST_STREAM before sending the GOAWAY,
|
|
+ // but the struture of the server's frame writer makes this difficult.
|
|
+ return nil, http2ConnectionError(http2ErrCodeProtocol)
|
|
+ }
|
|
+
|
|
+ // Also close the connection after any CONTINUATION frame following an
|
|
+ // invalid header, since we stop tracking the size of the headers after
|
|
+ // an invalid one.
|
|
+ if invalid != nil {
|
|
+ if http2VerboseLogs {
|
|
+ log.Printf("http2: invalid header: %v", invalid)
|
|
+ }
|
|
+ // It would be nice to send a RST_STREAM before sending the GOAWAY,
|
|
+ // but the struture of the server's frame writer makes this difficult.
|
|
+ return nil, http2ConnectionError(http2ErrCodeProtocol)
|
|
+ }
|
|
+
|
|
if _, err := hdec.Write(frag); err != nil {
|
|
return nil, http2ConnectionError(http2ErrCodeCompression)
|
|
}
|
|
--
|
|
2.33.0
|
|
|