33 lines
901 B
Diff
33 lines
901 B
Diff
From 3db352734472d851318944db13be73da61300568 Mon Sep 17 00:00:00 2001
|
|
From: Daiki Ueno <ueno@gnu.org>
|
|
Date: Wed, 22 Dec 2021 09:12:25 +0100
|
|
Subject: [PATCH] wrap_nettle_hash_fast: avoid calling _update with zero-length
|
|
input
|
|
|
|
As Nettle's hash update functions internally call memcpy, providing
|
|
zero-length input may cause undefined behavior.
|
|
|
|
Signed-off-by: Daiki Ueno <ueno@gnu.org>
|
|
---
|
|
lib/nettle/mac.c | 4 +++-
|
|
1 file changed, 3 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/lib/nettle/mac.c b/lib/nettle/mac.c
|
|
index f9d4d7a8df..35e070fab0 100644
|
|
--- a/lib/nettle/mac.c
|
|
+++ b/lib/nettle/mac.c
|
|
@@ -788,7 +788,9 @@ static int wrap_nettle_hash_fast(gnutls_digest_algorithm_t algo,
|
|
if (ret < 0)
|
|
return gnutls_assert_val(ret);
|
|
|
|
- ctx.update(&ctx, text_size, text);
|
|
+ if (text_size > 0) {
|
|
+ ctx.update(&ctx, text_size, text);
|
|
+ }
|
|
ctx.digest(&ctx, ctx.length, digest);
|
|
|
|
return 0;
|
|
--
|
|
GitLab
|
|
|