42 lines
1.7 KiB
Diff
42 lines
1.7 KiB
Diff
|
From 8a2cea0ae0cbd4120770b81f0be422f60f020e17 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Noah Goldstein <goldstein.w.n@gmail.com>
|
||
|
|
Date: Fri, 14 Jun 2024 13:01:58 -0500
|
||
|
|
Subject: [PATCH 06/10] x86: Fix value for `x86_memset_non_temporal_threshold`
|
||
|
|
when it is undesirable
|
||
|
|
|
||
|
|
When we don't want to use non-temporal stores for memset, we set
|
||
|
|
`x86_memset_non_temporal_threshold` to SIZE_MAX.
|
||
|
|
|
||
|
|
The current code, however, we using `maximum_non_temporal_threshold`
|
||
|
|
as the upper bound which is `SIZE_MAX >> 4` so we ended up with a
|
||
|
|
value of `0`.
|
||
|
|
|
||
|
|
Fix is to just use `SIZE_MAX` as the upper bound for when setting the
|
||
|
|
tunable.
|
||
|
|
Tested-by: Borislav Petkov (AMD) <bp@alien8.de>
|
||
|
|
Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
|
||
|
|
---
|
||
|
|
sysdeps/x86/dl-cacheinfo.h | 6 +++---
|
||
|
|
1 file changed, 3 insertions(+), 3 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/sysdeps/x86/dl-cacheinfo.h b/sysdeps/x86/dl-cacheinfo.h
|
||
|
|
index dfdb4069c7..a76df092e6 100644
|
||
|
|
--- a/sysdeps/x86/dl-cacheinfo.h
|
||
|
|
+++ b/sysdeps/x86/dl-cacheinfo.h
|
||
|
|
@@ -1101,9 +1101,9 @@ dl_init_cacheinfo (struct cpu_features *cpu_features)
|
||
|
|
TUNABLE_SET_WITH_BOUNDS (x86_non_temporal_threshold, non_temporal_threshold,
|
||
|
|
minimum_non_temporal_threshold,
|
||
|
|
maximum_non_temporal_threshold);
|
||
|
|
- TUNABLE_SET_WITH_BOUNDS (
|
||
|
|
- x86_memset_non_temporal_threshold, memset_non_temporal_threshold,
|
||
|
|
- minimum_non_temporal_threshold, maximum_non_temporal_threshold);
|
||
|
|
+ TUNABLE_SET_WITH_BOUNDS (x86_memset_non_temporal_threshold,
|
||
|
|
+ memset_non_temporal_threshold,
|
||
|
|
+ minimum_non_temporal_threshold, SIZE_MAX);
|
||
|
|
TUNABLE_SET_WITH_BOUNDS (x86_rep_movsb_threshold, rep_movsb_threshold,
|
||
|
|
minimum_rep_movsb_threshold, SIZE_MAX);
|
||
|
|
TUNABLE_SET_WITH_BOUNDS (x86_rep_stosb_threshold, rep_stosb_threshold, 1,
|
||
|
|
--
|
||
|
|
2.17.1
|
||
|
|
|