158 lines
6.8 KiB
Diff
158 lines
6.8 KiB
Diff
|
From 8254e1b9cd500e0c278465a3657543477e9d1250 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Richard Sandiford <richard.sandiford@arm.com>
|
||
|
|
Date: Tue, 12 Sep 2023 16:08:56 +0100
|
||
|
|
Subject: [PATCH] aarch64: Remove below_hard_fp_saved_regs_size
|
||
|
|
|
||
|
|
After previous patches, it's no longer necessary to store
|
||
|
|
saved_regs_size and below_hard_fp_saved_regs_size in the frame info.
|
||
|
|
All measurements instead use the top or bottom of the frame as
|
||
|
|
reference points.
|
||
|
|
|
||
|
|
gcc/
|
||
|
|
* config/aarch64/aarch64.h (aarch64_frame::saved_regs_size)
|
||
|
|
(aarch64_frame::below_hard_fp_saved_regs_size): Delete.
|
||
|
|
* config/aarch64/aarch64.cc (aarch64_layout_frame): Update accordingly.
|
||
|
|
---
|
||
|
|
gcc/config/aarch64/aarch64.cc | 45 ++++++++++++++++-------------------
|
||
|
|
gcc/config/aarch64/aarch64.h | 7 ------
|
||
|
|
2 files changed, 21 insertions(+), 31 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/gcc/config/aarch64/aarch64.cc b/gcc/config/aarch64/aarch64.cc
|
||
|
|
index a8d907df8843..ac3d3b336a37 100644
|
||
|
|
--- a/gcc/config/aarch64/aarch64.cc
|
||
|
|
+++ b/gcc/config/aarch64/aarch64.cc
|
||
|
|
@@ -8269,9 +8269,8 @@ aarch64_layout_frame (void)
|
||
|
|
|
||
|
|
/* OFFSET is now the offset of the hard frame pointer from the bottom
|
||
|
|
of the callee save area. */
|
||
|
|
- frame.below_hard_fp_saved_regs_size = offset - frame.bytes_below_saved_regs;
|
||
|
|
- bool saves_below_hard_fp_p
|
||
|
|
- = maybe_ne (frame.below_hard_fp_saved_regs_size, 0);
|
||
|
|
+ auto below_hard_fp_saved_regs_size = offset - frame.bytes_below_saved_regs;
|
||
|
|
+ bool saves_below_hard_fp_p = maybe_ne (below_hard_fp_saved_regs_size, 0);
|
||
|
|
gcc_assert (!saves_below_hard_fp_p
|
||
|
|
|| (frame.sve_save_and_probe != INVALID_REGNUM
|
||
|
|
&& known_eq (frame.reg_offset[frame.sve_save_and_probe],
|
||
|
|
@@ -8341,9 +8340,8 @@ aarch64_layout_frame (void)
|
||
|
|
|
||
|
|
offset = aligned_upper_bound (offset, STACK_BOUNDARY / BITS_PER_UNIT);
|
||
|
|
|
||
|
|
- frame.saved_regs_size = offset - frame.bytes_below_saved_regs;
|
||
|
|
- gcc_assert (known_eq (frame.saved_regs_size,
|
||
|
|
- frame.below_hard_fp_saved_regs_size)
|
||
|
|
+ auto saved_regs_size = offset - frame.bytes_below_saved_regs;
|
||
|
|
+ gcc_assert (known_eq (saved_regs_size, below_hard_fp_saved_regs_size)
|
||
|
|
|| (frame.hard_fp_save_and_probe != INVALID_REGNUM
|
||
|
|
&& known_eq (frame.reg_offset[frame.hard_fp_save_and_probe],
|
||
|
|
frame.bytes_below_hard_fp)));
|
||
|
|
@@ -8352,7 +8350,7 @@ aarch64_layout_frame (void)
|
||
|
|
The saving of the bottommost register counts as an implicit probe,
|
||
|
|
which allows us to maintain the invariant described in the comment
|
||
|
|
at expand_prologue. */
|
||
|
|
- gcc_assert (crtl->is_leaf || maybe_ne (frame.saved_regs_size, 0));
|
||
|
|
+ gcc_assert (crtl->is_leaf || maybe_ne (saved_regs_size, 0));
|
||
|
|
|
||
|
|
offset += get_frame_size ();
|
||
|
|
offset = aligned_upper_bound (offset, STACK_BOUNDARY / BITS_PER_UNIT);
|
||
|
|
@@ -8409,7 +8407,7 @@ aarch64_layout_frame (void)
|
||
|
|
|
||
|
|
HOST_WIDE_INT const_size, const_below_saved_regs, const_above_fp;
|
||
|
|
HOST_WIDE_INT const_saved_regs_size;
|
||
|
|
- if (known_eq (frame.saved_regs_size, 0))
|
||
|
|
+ if (known_eq (saved_regs_size, 0))
|
||
|
|
frame.initial_adjust = frame.frame_size;
|
||
|
|
else if (frame.frame_size.is_constant (&const_size)
|
||
|
|
&& const_size < max_push_offset
|
||
|
|
@@ -8422,7 +8420,7 @@ aarch64_layout_frame (void)
|
||
|
|
frame.callee_adjust = const_size;
|
||
|
|
}
|
||
|
|
else if (frame.bytes_below_saved_regs.is_constant (&const_below_saved_regs)
|
||
|
|
- && frame.saved_regs_size.is_constant (&const_saved_regs_size)
|
||
|
|
+ && saved_regs_size.is_constant (&const_saved_regs_size)
|
||
|
|
&& const_below_saved_regs + const_saved_regs_size < 512
|
||
|
|
/* We could handle this case even with data below the saved
|
||
|
|
registers, provided that that data left us with valid offsets
|
||
|
|
@@ -8441,8 +8439,7 @@ aarch64_layout_frame (void)
|
||
|
|
frame.initial_adjust = frame.frame_size;
|
||
|
|
}
|
||
|
|
else if (saves_below_hard_fp_p
|
||
|
|
- && known_eq (frame.saved_regs_size,
|
||
|
|
- frame.below_hard_fp_saved_regs_size))
|
||
|
|
+ && known_eq (saved_regs_size, below_hard_fp_saved_regs_size))
|
||
|
|
{
|
||
|
|
/* Frame in which all saves are SVE saves:
|
||
|
|
|
||
|
|
@@ -8464,7 +8461,7 @@ aarch64_layout_frame (void)
|
||
|
|
[save SVE registers relative to SP]
|
||
|
|
sub sp, sp, bytes_below_saved_regs */
|
||
|
|
frame.callee_adjust = const_above_fp;
|
||
|
|
- frame.sve_callee_adjust = frame.below_hard_fp_saved_regs_size;
|
||
|
|
+ frame.sve_callee_adjust = below_hard_fp_saved_regs_size;
|
||
|
|
frame.final_adjust = frame.bytes_below_saved_regs;
|
||
|
|
}
|
||
|
|
else
|
||
|
|
@@ -8479,7 +8476,7 @@ aarch64_layout_frame (void)
|
||
|
|
[save SVE registers relative to SP]
|
||
|
|
sub sp, sp, bytes_below_saved_regs */
|
||
|
|
frame.initial_adjust = frame.bytes_above_hard_fp;
|
||
|
|
- frame.sve_callee_adjust = frame.below_hard_fp_saved_regs_size;
|
||
|
|
+ frame.sve_callee_adjust = below_hard_fp_saved_regs_size;
|
||
|
|
frame.final_adjust = frame.bytes_below_saved_regs;
|
||
|
|
}
|
||
|
|
|
||
|
|
@@ -9621,17 +9618,17 @@ aarch64_epilogue_uses (int regno)
|
||
|
|
| local variables | <-- frame_pointer_rtx
|
||
|
|
| |
|
||
|
|
+-------------------------------+
|
||
|
|
- | padding | \
|
||
|
|
- +-------------------------------+ |
|
||
|
|
- | callee-saved registers | | frame.saved_regs_size
|
||
|
|
- +-------------------------------+ |
|
||
|
|
- | LR' | |
|
||
|
|
- +-------------------------------+ |
|
||
|
|
- | FP' | |
|
||
|
|
- +-------------------------------+ |<- hard_frame_pointer_rtx (aligned)
|
||
|
|
- | SVE vector registers | | \
|
||
|
|
- +-------------------------------+ | | below_hard_fp_saved_regs_size
|
||
|
|
- | SVE predicate registers | / /
|
||
|
|
+ | padding |
|
||
|
|
+ +-------------------------------+
|
||
|
|
+ | callee-saved registers |
|
||
|
|
+ +-------------------------------+
|
||
|
|
+ | LR' |
|
||
|
|
+ +-------------------------------+
|
||
|
|
+ | FP' |
|
||
|
|
+ +-------------------------------+ <-- hard_frame_pointer_rtx (aligned)
|
||
|
|
+ | SVE vector registers |
|
||
|
|
+ +-------------------------------+
|
||
|
|
+ | SVE predicate registers |
|
||
|
|
+-------------------------------+
|
||
|
|
| dynamic allocation |
|
||
|
|
+-------------------------------+
|
||
|
|
diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
|
||
|
|
index 46d4693e2064..01f7751bc783 100644
|
||
|
|
--- a/gcc/config/aarch64/aarch64.h
|
||
|
|
+++ b/gcc/config/aarch64/aarch64.h
|
||
|
|
@@ -871,18 +871,11 @@ struct GTY (()) aarch64_frame
|
||
|
|
STACK_BOUNDARY. */
|
||
|
|
HOST_WIDE_INT saved_varargs_size;
|
||
|
|
|
||
|
|
- /* The size of the callee-save registers with a slot in REG_OFFSET. */
|
||
|
|
- poly_int64 saved_regs_size;
|
||
|
|
-
|
||
|
|
/* The number of bytes between the bottom of the static frame (the bottom
|
||
|
|
of the outgoing arguments) and the bottom of the register save area.
|
||
|
|
This value is always a multiple of STACK_BOUNDARY. */
|
||
|
|
poly_int64 bytes_below_saved_regs;
|
||
|
|
|
||
|
|
- /* The size of the callee-save registers with a slot in REG_OFFSET that
|
||
|
|
- are saved below the hard frame pointer. */
|
||
|
|
- poly_int64 below_hard_fp_saved_regs_size;
|
||
|
|
-
|
||
|
|
/* The number of bytes between the bottom of the static frame (the bottom
|
||
|
|
of the outgoing arguments) and the hard frame pointer. This value is
|
||
|
|
always a multiple of STACK_BOUNDARY. */
|
||
|
|
--
|
||
|
|
2.43.5
|
||
|
|
|