85 lines
2.7 KiB
Diff
85 lines
2.7 KiB
Diff
From a882e725dd057db98907f6b03b733f0f6889aee7 Mon Sep 17 00:00:00 2001
|
|
From: Sebastian Pipping <sebastian@pipping.org>
|
|
Date: Tue, 20 Aug 2024 22:57:12 +0200
|
|
Subject: [PATCH] tests: Cover "len < 0" for both XML_Parse and XML_ParseBuffer
|
|
|
|
---
|
|
tests/runtests.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++
|
|
1 file changed, 53 insertions(+)
|
|
|
|
diff --git a/tests/runtests.c b/tests/runtests.c
|
|
index 02c8c85..4649359 100644
|
|
--- a/tests/runtests.c
|
|
+++ b/tests/runtests.c
|
|
@@ -3978,6 +3978,57 @@ START_TEST(test_empty_parse) {
|
|
}
|
|
END_TEST
|
|
|
|
+/* Test XML_Parse for len < 0 */
|
|
+START_TEST(test_negative_len_parse) {
|
|
+ const char *const doc = "<root/>";
|
|
+ for (int isFinal = 0; isFinal < 2; isFinal++) {
|
|
+ XML_Parser parser = XML_ParserCreate(NULL);
|
|
+
|
|
+ if (XML_GetErrorCode(parser) != XML_ERROR_NONE)
|
|
+ fail("There was not supposed to be any initial parse error.");
|
|
+
|
|
+ const enum XML_Status status = XML_Parse(parser, doc, -1, isFinal);
|
|
+
|
|
+ if (status != XML_STATUS_ERROR)
|
|
+ fail("Negative len was expected to fail the parse but did not.");
|
|
+
|
|
+ if (XML_GetErrorCode(parser) != XML_ERROR_INVALID_ARGUMENT)
|
|
+ fail("Parse error does not match XML_ERROR_INVALID_ARGUMENT.");
|
|
+
|
|
+ XML_ParserFree(parser);
|
|
+ }
|
|
+}
|
|
+END_TEST
|
|
+
|
|
+/* Test XML_ParseBuffer for len < 0 */
|
|
+START_TEST(test_negative_len_parse_buffer) {
|
|
+ const char *const doc = "<root/>";
|
|
+ for (int isFinal = 0; isFinal < 2; isFinal++) {
|
|
+ XML_Parser parser = XML_ParserCreate(NULL);
|
|
+
|
|
+ if (XML_GetErrorCode(parser) != XML_ERROR_NONE)
|
|
+ fail("There was not supposed to be any initial parse error.");
|
|
+
|
|
+ void *const buffer = XML_GetBuffer(parser, (int)strlen(doc));
|
|
+
|
|
+ if (buffer == NULL)
|
|
+ fail("XML_GetBuffer failed.");
|
|
+
|
|
+ memcpy(buffer, doc, strlen(doc));
|
|
+
|
|
+ const enum XML_Status status = XML_ParseBuffer(parser, -1, isFinal);
|
|
+
|
|
+ if (status != XML_STATUS_ERROR)
|
|
+ fail("Negative len was expected to fail the parse but did not.");
|
|
+
|
|
+ if (XML_GetErrorCode(parser) != XML_ERROR_INVALID_ARGUMENT)
|
|
+ fail("Parse error does not match XML_ERROR_INVALID_ARGUMENT.");
|
|
+
|
|
+ XML_ParserFree(parser);
|
|
+ }
|
|
+}
|
|
+END_TEST
|
|
+
|
|
/* Test odd corners of the XML_GetBuffer interface */
|
|
static enum XML_Status
|
|
get_feature(enum XML_FeatureEnum feature_id, long *presult) {
|
|
@@ -12474,6 +12525,8 @@ make_suite(void) {
|
|
tcase_add_test__ifdef_xml_dtd(tc_basic, test_user_parameters);
|
|
tcase_add_test__ifdef_xml_dtd(tc_basic, test_ext_entity_ref_parameter);
|
|
tcase_add_test(tc_basic, test_empty_parse);
|
|
+ tcase_add_test(tc_basic, test_negative_len_parse);
|
|
+ tcase_add_test(tc_basic, test_negative_len_parse_buffer);
|
|
tcase_add_test(tc_basic, test_get_buffer_1);
|
|
tcase_add_test(tc_basic, test_get_buffer_2);
|
|
#if defined(XML_CONTEXT_BYTES)
|
|
--
|
|
2.33.0
|
|
|
|
|