misc/fsck.c: Processes may kill other processes.

0018-misc-fsck.c-Processes-may-kill-other-processes.patch

@@ -0,0 +1,39 @@
+From d08ef863feae14e4710bf2026404e6c6e06db2be Mon Sep 17 00:00:00 2001
+From: zhanchengbin <zhanchengbin1@huawei.com>
+Date: Mon, 10 Oct 2022 16:56:58 +0800
+Subject: [PATCH] misc/fsck.c: Processes may kill other processes.
+
+I find a error in misc/fsck.c, if run the fsck -N command, processes
+don't execute, just show what would be done. However, the pid whose
+value is -1 is added to the instance_list list in the execute
+function,if the kill_all function is called later, kill(-1, signum)
+is executed, Signals are sent to all processes except the number one
+process and itself. Other processes will be killed if they use the
+default signal processing function.
+
+Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
+Signed-off-by: Lukas Czerner <lczerner@redhat.com>
+Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
+Reviewed-by: Darrick J. Wong <djwong@kernel.org>
+Reviewed-by: Lukas Czerner <lczerner@redhat.com>
+Signed-off-by: Theodore Ts'o <tytso@mit.edu>
+---
+ misc/fsck.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/misc/fsck.c b/misc/fsck.c
+index 1f6ec7d9..1769a106 100644
+--- a/misc/fsck.c
++++ b/misc/fsck.c
+@@ -547,6 +547,8 @@ static int kill_all(int signum)
+ 	for (inst = instance_list; inst; inst = inst->next) {
+ 		if (inst->flags & FLAG_DONE)
+ 			continue;
++		if (inst->pid <= 0)
++			continue;
+ 		kill(inst->pid, signum);
+ 		n++;
+ 	}
+-- 
+2.38.1
+

e2fsprogs.spec

@@ -1,6 +1,6 @@
 Name:           e2fsprogs
 Version:        1.46.5
-Release:        2
+Release:        3
 Summary:        Second extended file system management tools
 License:        GPLv2+ and LGPLv2 and MIT
 URL:            http://e2fsprogs.sourceforge.net/
@@ -24,6 +24,7 @@ Patch14:	0014-tune2fs-fix-tune2fs-segfault-when-ext2fs_run_ext3_jo.patch
 Patch15:	0015-tune2fs-tune2fs_main-should-return-rc-when-some-erro.patch
 Patch16:	0016-tune2fs-exit-directly-when-fs-freed-in-ext2fs_run_ext3_journal.patch
 Patch17:	0017-unix_io.c-fix-deadlock-problem-in-unix_write_blk64.patch
+Patch18:	0018-misc-fsck.c-Processes-may-kill-other-processes.patch
 
 
 BuildRequires:  gcc pkgconfig texinfo
@@ -165,6 +166,9 @@ exit 0
 %{_mandir}/man8/*
 
 %changelog
+* Mon Jan 30 2023 zhanchengbin <zhanchengbin1@huawei.com> - 1.46.5-3
+- misc/fsck.c: Processes may kill other processes.
+
 * Thu Dec 1 2022 Zhiqiang Liu <liuzhiqiang26@huawei.com> - 1.46.5-2
 - fix deadlock problem in unix_write_blk64