2020-07-28 16:39:08 +08:00
From 5db7b109af8f6967335806b50d628611be7b9cfd Mon Sep 17 00:00:00 2001
From: xiaoweiwei <xiaoweiwei5@huawei.com>
Date: Tue, 28 Jul 2020 15:22:54 +0800
Subject: [PATCH] bugfix allow binding mac with ipv6
2019-12-25 15:44:46 +08:00
---
src/dnsmasq.c | 1 +
2020-07-28 16:39:08 +08:00
src/dnsmasq.h | 2 ++
2019-12-25 15:44:46 +08:00
src/option.c | 3 +++
2020-07-28 16:39:08 +08:00
src/rfc3315.c | 32 +++++++++++++++++++++++++++++++-
4 files changed, 37 insertions(+), 1 deletion(-)
2019-12-25 15:44:46 +08:00
diff --git a/src/dnsmasq.c b/src/dnsmasq.c
2020-07-28 16:39:08 +08:00
index bfad87f..b25e0c9 100644
2019-12-25 15:44:46 +08:00
--- a/src/dnsmasq.c
+++ b/src/dnsmasq.c
2020-07-28 16:39:08 +08:00
@@ -261,6 +261,7 @@ int main (int argc, char **argv)
2019-12-25 15:44:46 +08:00
if (daemon->dhcp6)
{
daemon->doing_ra = option_bool(OPT_RA);
+ daemon->bind_mac_with_ip6 = option_bool(OPT_BIND_MAC_IP6);
for (context = daemon->dhcp6; context; context = context->next)
{
diff --git a/src/dnsmasq.h b/src/dnsmasq.h
2020-07-28 16:39:08 +08:00
index 4220798..b9054b9 100644
2019-12-25 15:44:46 +08:00
--- a/src/dnsmasq.h
+++ b/src/dnsmasq.h
2020-07-28 16:39:08 +08:00
@@ -270,6 +270,7 @@ struct event_desc {
#define OPT_SINGLE_PORT 60
#define OPT_LEASE_RENEW 61
#define OPT_LAST 62
+#define OPT_BIND_MAC_IP6 63
2019-12-25 15:44:46 +08:00
2020-07-28 16:39:08 +08:00
#define OPTION_BITS (sizeof(unsigned int)*8)
#define OPTION_SIZE ( (OPT_LAST/OPTION_BITS)+((OPT_LAST%OPTION_BITS)!=0) )
@@ -1051,6 +1052,7 @@ extern struct daemon {
2019-12-25 15:44:46 +08:00
int override;
int enable_pxe;
int doing_ra, doing_dhcp6;
+ int bind_mac_with_ip6;
struct dhcp_netid_list *dhcp_ignore, *dhcp_ignore_names, *dhcp_gen_names;
struct dhcp_netid_list *force_broadcast, *bootp_dynamic;
struct hostsfile *dhcp_hosts_file, *dhcp_opts_file, *dynamic_dirs;
diff --git a/src/option.c b/src/option.c
2020-07-28 16:39:08 +08:00
index dbe5f90..f8391d0 100644
2019-12-25 15:44:46 +08:00
--- a/src/option.c
+++ b/src/option.c
2020-07-28 16:39:08 +08:00
@@ -167,6 +167,7 @@ struct myoption {
#define LOPT_IGNORE_CLID 358
#define LOPT_SINGLE_PORT 359
#define LOPT_SCRIPT_TIME 360
+#define LOPT_BIND_MAC_IP6 361
2019-12-25 15:44:46 +08:00
#ifdef HAVE_GETOPT_LONG
static const struct option opts[] =
2020-07-28 16:39:08 +08:00
@@ -339,6 +340,7 @@ static const struct myoption opts[] =
{ "dumpfile", 1, 0, LOPT_DUMPFILE },
{ "dumpmask", 1, 0, LOPT_DUMPMASK },
{ "dhcp-ignore-clid", 0, 0, LOPT_IGNORE_CLID },
+ { "bind-mac-with-ip6",0, 0, LOPT_BIND_MAC_IP6},
2019-12-25 15:44:46 +08:00
{ NULL, 0, 0, 0 }
};
2020-07-28 16:39:08 +08:00
@@ -518,6 +520,7 @@ static struct {
{ LOPT_DUMPFILE, ARG_ONE, "<path>", gettext_noop("Path to debug packet dump file"), NULL },
{ LOPT_DUMPMASK, ARG_ONE, "<hex>", gettext_noop("Mask which packets to dump"), NULL },
{ LOPT_SCRIPT_TIME, OPT_LEASE_RENEW, NULL, gettext_noop("Call dhcp-script when lease expiry changes."), NULL },
2019-12-25 15:44:46 +08:00
+ { LOPT_BIND_MAC_IP6, OPT_BIND_MAC_IP6, NULL, gettext_noop("Bind mac with ipv6 address. This is an experimental feature and it conflicts with rfc3315."), NULL },
{ 0, 0, NULL, NULL, NULL }
};
diff --git a/src/rfc3315.c b/src/rfc3315.c
2020-07-28 16:39:08 +08:00
index b3f0a0a..5781809 100644
2019-12-25 15:44:46 +08:00
--- a/src/rfc3315.c
+++ b/src/rfc3315.c
2020-07-28 16:39:08 +08:00
@@ -49,6 +49,7 @@ static void end_ia(int t1cntr, unsigned int min_time, int do_fuzz);
2019-12-25 15:44:46 +08:00
static void mark_context_used(struct state *state, struct in6_addr *addr);
static void mark_config_used(struct dhcp_context *context, struct in6_addr *addr);
static int check_address(struct state *state, struct in6_addr *addr);
+static int check_and_try_preempte_address(struct state *state, struct in6_addr *addr, time_t now, struct dhcp_config *config);
2020-07-28 16:39:08 +08:00
static int config_valid(struct dhcp_config *config, struct dhcp_context *context, struct in6_addr *addr, struct state *state, time_t now);
static struct addrlist *config_implies(struct dhcp_config *config, struct dhcp_context *context, struct in6_addr *addr);
2019-12-25 15:44:46 +08:00
static void add_address(struct state *state, struct dhcp_context *context, unsigned int lease_time, void *ia_option,
2020-07-28 16:39:08 +08:00
@@ -703,7 +704,8 @@ static int dhcp6_no_relay(struct state *state, int msg_type, void *inbuff, size_
for (c = state->context; c; c = c->current)
2019-12-25 15:44:46 +08:00
if (!(c->flags & CONTEXT_CONF_USED) &&
match_netid(c->filter, solicit_tags, plain_range) &&
2020-07-28 16:39:08 +08:00
- config_valid(config, c, &addr, state, now))
+ config_valid(config, c, &addr, state, now) &&
+ check_and_try_preempte_address(state, &addr, now, config))
2019-12-25 15:44:46 +08:00
{
mark_config_used(state->context, &addr);
if (have_config(config, CONFIG_TIME))
2020-07-28 16:39:08 +08:00
@@ -1684,6 +1686,34 @@ static int check_address(struct state *state, struct in6_addr *addr)
2019-12-25 15:44:46 +08:00
return 1;
}
2020-07-28 16:39:08 +08:00
+static int check_and_try_preempte_address(struct state *state, struct in6_addr *addr, time_t now, struct dhcp_config *config){
2019-12-25 15:44:46 +08:00
+ struct dhcp_lease *lease;
+
+ if (!(lease = lease6_find_by_addr(addr, 128, 0)))
+ {
+ return 1;
+ }
+
2020-07-28 16:39:08 +08:00
+ if (daemon->bind_mac_with_ip6) {
2019-12-25 15:44:46 +08:00
+ // break rfc3315 here
+ // bind mac address with a lease
+ if ((state->mac) && !(config->flags & CONFIG_CLID) &&
+ config_has_mac(config, state->mac, state->mac_len, state->mac_type)) {
+ lease_prune(lease, now);
+ return 1;
+ }
+ }
+
+ // what rfc3315 do
+ if (lease->clid_len != state->clid_len ||
+ memcmp(lease->clid, state->clid, state->clid_len) != 0 ||
+ lease->iaid != state->iaid)
2020-07-28 16:39:08 +08:00
+ {
+ return 0;
+ }
2019-12-25 15:44:46 +08:00
+
+ return 1;
+}
2020-07-28 16:39:08 +08:00
/* return true of *addr could have been generated from config. */
static struct addrlist *config_implies(struct dhcp_config *config, struct dhcp_context *context, struct in6_addr *addr)
2019-12-25 15:44:46 +08:00
--
2020-07-28 16:39:08 +08:00
1.8.3.1
2019-12-25 15:44:46 +08:00